angular-material: Fix unfocused description display for number renderer by lucas-koehler · Pull Request #2167 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
angular-material: Fix unfocused description display for number renderer#2167
lucas-koehler merged 1 commit intomasterfrom
angular-material: Fix unfocused description display for number renderer#2167
lucas-koehler merged 1 commit intomasterfrom
Conversation
Copy link
Contributor
lucas-koehler
commented
Jul 27, 2023
lucas-koehler
commented
The template had a bug closing the ngIf that checks whether the description is shown too early. This lead to a DOMException and the description to never be shown.
Fix #2166
The template had a bug closing the ngIf that checks whether the description is shown too early. This lead to a DOMException and the description to never be shown. Fix #2166
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | e97e03b |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/64c24858473007000860fc3a |
| 😎 Deploy Preview | https://deploy-preview-2167--jsonforms-examples.netlify.app |
| 📱 Preview on mobile |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
coveralls
commented
Jul 27, 2023
coveralls commented
Jul 27, 2023sdirix approved these changes Jul 27, 2023
lucas-koehler
merged commit
e80a873
into
master
lucas-koehler
deleted the
2166-angular-number-renderer-bug
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment