angular-material: Fix unfocused description display for number renderer by lucas-koehler · Pull Request #2167 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lucas-koehler

Copy link

Contributor

The template had a bug closing the ngIf that checks whether the description is shown too early. This lead to a DOMException and the description to never be shown.

Fix #2166

The template had a bug closing the ngIf that checks whether the description
is shown too early. This lead to a DOMException and the description to never be shown.

Fix #2166

@netlify

Copy link

netlify bot commented

Jul 27, 2023

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit e97e03b
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/64c24858473007000860fc3a
😎 Deploy Preview https://deploy-preview-2167--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls

Copy link

Coverage Status

coverage: 84.254%. remained the same when pulling e97e03b on 2166-angular-number-renderer-bug into 071b320 on master.

@lucas-koehler lucas-koehler merged commit e80a873 into master

Jul 27, 2023

@lucas-koehler lucas-koehler deleted the 2166-angular-number-renderer-bug branch

July 27, 2023 12:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ERROR DOMException in browser console

3 participants

@lucas-koehler @coveralls @sdirix