fix createRenderInfo TypeError in default title case by DrewHoo · Pull Request #2169 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
lucas-koehler merged 9 commits intoeclipsesource:masterfrom
Aug 11, 2023Merged
Conversation
Copy link
Contributor
DrewHoo
commented
Aug 9, 2023
DrewHoo
commented
I realized there's a possible error here, added a test & fix for it in last commit
DrewHoo and others added 8 commits
July 18, 2023 16:54
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 7ccdfb9 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/64d39fc3e4f8c60007f4ef59 |
| 😎 Deploy Preview | https://deploy-preview-2169--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
Contributor Author
DrewHoo
commented
Aug 9, 2023
DrewHoo commented
Aug 9, 2023@sdirix see test case here--I think there's a bug if there's neither a resolved schema or a title.
DrewHoo
changed the title
2164 fix renderinfo labels for any of refs
fix createRenderInfo TypeError in default title case
lucas-koehler approved these changes Aug 11, 2023
Copy link
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DrewHoo
thank you very much for the contribution <3
The fix and the test case look good to me :)
Copy link
coveralls
commented
Aug 11, 2023
coveralls commented
Aug 11, 2023
lucas-koehler
added this to the
3.2 milestone
lucas-koehler
merged commit
e685ae8
into
eclipsesource:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants