core: fix removeItems for list renderers by xou816 · Pull Request #2181 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@xou816

Copy link

Contributor

@xou816 xou816 commented

Sep 29, 2023

edited

Loading

Fixes #2180

@CLAassistant

Copy link

CLAassistant commented

Sep 29, 2023

edited

Loading

CLA assistant check
All committers have signed the CLA.

@netlify

Copy link

netlify bot commented

Sep 29, 2023

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 29be9cb
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65170f74dc930700080500b4
😎 Deploy Preview https://deploy-preview-2181--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@lucas-koehler lucas-koehler self-requested a review

October 4, 2023 10:27

@coveralls

Copy link

Coverage Status

coverage: 84.469%. remained the same when pulling 29be9cb on xou816:fix-2180 into 8fc90d3 on eclipsesource:master.

Copy link

Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xou816 ,
thanks for contributing this fix and opening the corresponding issue ❤️
The changes look good to me!

@lucas-koehler lucas-koehler merged commit 28eeeca into eclipsesource:master

Oct 4, 2023

@xou816

Copy link

Contributor Author

xou816 commented

Oct 4, 2023

You're welcome! :)

lucas-koehler reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-koehler lucas-koehler lucas-koehler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

List renderer HOC: removeItems does not handle indices above 10 properly

4 participants

@xou816 @CLAassistant @coveralls @lucas-koehler