generate a control for enums in generated uischema by LukasBoll · Pull Request #2189 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
lucas-koehler merged 1 commit intoeclipsesource:masterfrom
Oct 25, 2023Merged
generate a control for enums in generated uischema#2189
lucas-koehler merged 1 commit intoeclipsesource:masterfrom
generate a control for enums in generated uischema#2189
lucas-koehler merged 1 commit intoeclipsesource:masterfrom
Conversation
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 6e38cea |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/65379c01ca298c0008782c00 |
| 😎 Deploy Preview | https://deploy-preview-2189--jsonforms-examples.netlify.app |
| 📱 Preview on mobile |
To edit notification comments on pull requests, go to your Netlify site configuration.
LukasBoll
force-pushed
the
enum_generated_uischema
branch
from
b6ebee9 to
14842a5
Compare
Copy link
LukasBoll
force-pushed
the
enum_generated_uischema
branch
from
14842a5 to
b88cbe7
Compare
Previously, enums without type-attribute weren't recognized by the derive types function, leading to omitted enums in generated uischemas. Closes eclipsesource#2177
LukasBoll
force-pushed
the
enum_generated_uischema
branch
from
b88cbe7 to
6e38cea
Compare
lucas-koehler
self-requested a review
sdirix reviewed Oct 24, 2023
packages/core/src/util/util.ts
Show resolved
Hide resolved
packages/core/src/util/util.ts Show resolved Hide resolved
lucas-koehler approved these changes Oct 24, 2023
Copy link
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks :)
lucas-koehler
merged commit
f905c82
into
eclipsesource:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment