Generate valid path segments when schemaPath contains 10 or more subschemas. by fuku710 · Pull Request #2194 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@fuku710

Copy link

Contributor

@fuku710 fuku710 commented

Oct 19, 2023

Resolves #2193

Regular expression did not match when schemaPath contains 10 or more subschemas.

@netlify

Copy link

netlify bot commented

Oct 19, 2023

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit c6618c3
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65311394278aa50008bf6380
😎 Deploy Preview https://deploy-preview-2194--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant

Copy link

CLAassistant commented

Oct 19, 2023

edited

Loading

CLA assistant check
All committers have signed the CLA.

@sdirix

Copy link

Member

sdirix commented

Oct 19, 2023

Thanks for the contribution! We'll take a look!

@coveralls

Copy link

Coverage Status

coverage: 84.469%. remained the same when pulling c6618c3 on fuku710:fix-to-data-path-segments into 9146b0f on eclipsesource:master.

Copy link

Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution ❤️

@sdirix sdirix merged commit 90d5db2 into eclipsesource:master

Oct 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Forms rendered with invalid path when scope contains anyOf with 10 or more subschemas

4 participants

@fuku710 @CLAassistant @sdirix @coveralls