BUGFIX: Orphaned labels on single select dropdown by sgober · Pull Request #2199 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
BUGFIX: Orphaned labels on single select dropdown#2199
sdirix merged 1 commit intoeclipsesource:masterfrom
sgober:patch-1
BUGFIX: Orphaned labels on single select dropdown#2199
sdirix merged 1 commit intoeclipsesource:masterfrom
sgober:patch-1
Conversation
Copy link
Contributor
sgober
commented
Oct 26, 2023
sgober
commented
Removed "-input" from id on input so that the label and input are associated correctly. Will fix issue #2198
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 922f2cf |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/653a75312145ac0008838a24 |
| 😎 Deploy Preview | https://deploy-preview-2199--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
All committers have signed the CLA.
sgober
changed the title
remove "-input" from id on input
BUGFIX: Orphaned labels on single select dropdown
sgober
mentioned this pull request
Copy link
coveralls
commented
Oct 26, 2023
coveralls commented
Oct 26, 2023
Copy link
Member
sdirix
commented
Oct 27, 2023
sdirix commented
Oct 27, 2023Thanks for the contribution ❤️ We will take a look soon
sdirix approved these changes Nov 13, 2023
Copy link
Member
sdirix
left a comment
sdirix
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me as intended. Thanks for the contribution ❤️
sdirix
merged commit
6a739a6
into
eclipsesource:master
sdirix
added this to the
3.2 milestone
sdirix
added
react
material
bug
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment