Use `options.value` instead of `ev.currentTarget.value` for value handling within vanilla-renderers by TheZoker · Pull Request #2205 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
sdirix merged 5 commits intoeclipsesource:masterfrom
Nov 13, 2023Merged
Conversation
Copy link
Contributor
TheZoker
commented
Oct 31, 2023
TheZoker
commented
This PR fixes a couple of issues:
- Fix the folder reference for the example apps in the README file
- Fix the
indexfile naming within the example folder ofvanilla-renderer(bug introduced in Make material renderers aware of input variant in theme #2182) - Use
options.valueinstead ofev.currentTarget.valuefor value handling to preserve the type of the value
Fixes #2045
TheZoker added 2 commits
October 31, 2023 01:23Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 00968ee |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/654a0a144df9ef0008341e76 |
| 😎 Deploy Preview | https://deploy-preview-2205--jsonforms-examples.netlify.app |
| 📱 Preview on mobile |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
TheZoker added 2 commits
October 31, 2023 01:43sdirix approved these changes Nov 13, 2023
Copy link
Member
sdirix
left a comment
sdirix
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sdirix
merged commit
ddabac6
into
eclipsesource:master
TheZoker
deleted the
fix-radio-option-type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment