Use `options.value` instead of `ev.currentTarget.value` for value handling within vanilla-renderers by TheZoker · Pull Request #2205 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@TheZoker

Copy link

Contributor

This PR fixes a couple of issues:

  • Fix the folder reference for the example apps in the README file
  • Fix the index file naming within the example folder of vanilla-renderer (bug introduced in Make material renderers aware of input variant in theme #2182)
  • Use options.value instead of ev.currentTarget.value for value handling to preserve the type of the value

Fixes #2045

@netlify

Copy link

netlify bot commented

Oct 31, 2023

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 00968ee
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/654a0a144df9ef0008341e76
😎 Deploy Preview https://deploy-preview-2205--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls

Copy link

coveralls commented

Oct 31, 2023

edited

Loading

Coverage Status

coverage: 84.469%. remained the same
when pulling 00968ee on TheZoker:fix-radio-option-type
into f905c82 on eclipsesource:master.

Copy link

Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdirix sdirix merged commit ddabac6 into eclipsesource:master

Nov 13, 2023

@TheZoker TheZoker deleted the fix-radio-option-type branch

November 13, 2023 22:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vanilla react renderer: integer enum radio group values are converted to string

3 participants

@TheZoker @coveralls @sdirix