fix: remove @jsonforms/angular-test peerDependency by sdirix · Pull Request #2230 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
lucas-koehler merged 1 commit intoeclipsesource:masterfrom
Dec 18, 2023Merged
fix: remove @jsonforms/angular-test peerDependency#2230
lucas-koehler merged 1 commit intoeclipsesource:masterfrom
fix: remove @jsonforms/angular-test peerDependency#2230
lucas-koehler merged 1 commit intoeclipsesource:masterfrom
Conversation
Copy link
Member
sdirix
commented
Dec 15, 2023
sdirix
commented
The @jsonforms/angular-material package specified
@jsonforms/angular-test as peerDependency. This is now removed.
The @jsonforms/angular-material package specified @jsonforms/angular-test as peerDependency. This is now removed.
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | b670a40 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/657c879f36e9a500080d1aa2 |
| 😎 Deploy Preview | https://deploy-preview-2230--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
sdirix
requested a review
from lucas-koehler
Copy link
coveralls
commented
Dec 15, 2023
coveralls commented
Dec 15, 2023lucas-koehler approved these changes Dec 18, 2023
Copy link
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks :)
lucas-koehler
merged commit
a7d3268
into
eclipsesource:master
sdirix
deleted the
remove-angular-test-dependency
branch
sdirix
added
material
angular
labels
sdirix
added this to the
3.2 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment