fix: always hide React Material multi enum when not visible by sdirix · Pull Request #2252 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
fix: always hide React Material multi enum when not visible#2252
lucas-koehler merged 1 commit intomasterfrom
fix: always hide React Material multi enum when not visible#2252
lucas-koehler merged 1 commit intomasterfrom
Conversation
Copy link
Member
sdirix
commented
Jan 19, 2024
sdirix
commented
The 'Hidden' of the MaterialEnumArrayRenderer only applied from screen size 'xl' and larger. However it should always apply. This fix changes 'xlUp' to 'xsUp', therefore the control is hidden on all screen sizes.
The 'Hidden' of the MaterialEnumArrayRenderer only applied from screen size 'xl' and larger. However it should always apply. This fix changes 'xlUp' to 'xsUp', therefore the control is hidden on all screen sizes.
sdirix
requested a review
from lucas-koehler
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 659440c |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/65aaa8c04d489b00088f469a |
| 😎 Deploy Preview | https://deploy-preview-2252--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
coveralls
commented
Jan 19, 2024
coveralls commented
Jan 19, 2024lucas-koehler approved these changes Jan 22, 2024
Copy link
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix :)
lucas-koehler
merged commit
c5f28e6
into
master
lucas-koehler
deleted the
fix-material-enum-array-visbility
branch
sdirix
added this to the
3.2 milestone
sdirix
added
react
material
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment