dev: reverse push and publish operations by sdirix · Pull Request #2259 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
dev: reverse push and publish operations#2259
lucas-koehler merged 1 commit intomasterfrom
dev: reverse push and publish operations#2259
lucas-koehler merged 1 commit intomasterfrom
Conversation
Copy link
Member
sdirix
commented
Jan 24, 2024
sdirix
commented
In the publish workflow we first pushed the release to npm and then pushed the commit to Github. If there was any error during pushing, the published release would point to a non-existing commit. Therefore these operations are now reversed so that this can not happen.
In the publish workflow we first pushed the release to npm and then pushed the commit to Github. If there was any error during pushing, the published release would point to a non-existing commit. Therefore these operations are now reversed so that this can not happen.
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 9201f79 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/65b131727bb66e0008763848 |
| 😎 Deploy Preview | https://deploy-preview-2259--jsonforms-examples.netlify.app |
| 📱 Preview on mobile |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
coveralls
commented
Jan 24, 2024
coveralls commented
Jan 24, 2024lucas-koehler approved these changes Jan 26, 2024
Copy link
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
lucas-koehler
merged commit
7f8134a
into
master
lucas-koehler
deleted the
reverse-push-publish-order
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment