dev: reverse push and publish operations by sdirix · Pull Request #2259 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@sdirix

Copy link

Member

@sdirix sdirix commented

Jan 24, 2024

In the publish workflow we first pushed the release to npm and then pushed the commit to Github. If there was any error during pushing, the published release would point to a non-existing commit. Therefore these operations are now reversed so that this can not happen.

In the publish workflow we first pushed the release to npm and then
pushed the commit to Github. If there was any error during pushing,
the published release would point to a non-existing commit. Therefore
these operations are now reversed so that this can not happen.

@netlify

Copy link

netlify bot commented

Jan 24, 2024

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 9201f79
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65b131727bb66e0008763848
😎 Deploy Preview https://deploy-preview-2259--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls

Copy link

Coverage Status

coverage: 84.796%. remained the same
when pulling 9201f79 on reverse-push-publish-order
into 9d3f706 on master.

Copy link

Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucas-koehler lucas-koehler merged commit 7f8134a into master

Feb 2, 2024

@lucas-koehler lucas-koehler deleted the reverse-push-publish-order branch

February 2, 2024 13:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-koehler lucas-koehler lucas-koehler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdirix @coveralls @lucas-koehler