dev: add simple grid layout to the dev app. save example name at location hash. show schema and uischema by davewwww · Pull Request #2269 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@davewwww

Copy link

Contributor

@davewwww davewwww commented

Feb 5, 2024

i also stored the selected example at the location hash. and i have added the schema and uischema.

@netlify

Copy link

netlify bot commented

Feb 5, 2024

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 1a2ada7
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65c1f86aba805500088cd80d
😎 Deploy Preview https://deploy-preview-2269--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@sdirix

Copy link

Member

sdirix commented

Feb 6, 2024

Thanks for this contribution ❤️ We will take a look soon 👍

@coveralls

Copy link

Coverage Status

coverage: 84.796%. remained the same
when pulling 1a2ada7 on davewwww:dev-app-with-grid-layout
into e06f5e8 on eclipsesource:master.

Copy link

Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davewwww , thanks for this great improvement of the dev/example app ❤️ The changes LGTM!

davewwww reacted with heart emoji

@lucas-koehler lucas-koehler merged commit 0cec549 into eclipsesource:master

Feb 13, 2024

@lucas-koehler lucas-koehler added this to the 3.3 milestone

Feb 13, 2024

@davewwww davewwww deleted the dev-app-with-grid-layout branch

February 13, 2024 08:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-koehler lucas-koehler lucas-koehler approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@davewwww @sdirix @coveralls @lucas-koehler