Allow the translation of the No Data case for MaterialArrayLayout by Maxouwell · Pull Request #2286 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
sdirix merged 3 commits intoeclipsesource:masterfrom
Feb 20, 2024Merged
Conversation
Copy link
All committers have signed the CLA.
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | e15357a |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/65d37ca76a32e900082da96e |
| 😎 Deploy Preview | https://deploy-preview-2286--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
Contributor
lucas-koehler
commented
Feb 16, 2024
lucas-koehler commented
Feb 16, 2024Hi @Maxouwell , thanks for the PR ❤️ We'll have a look soon.
sdirix approved these changes Feb 19, 2024
Copy link
Member
sdirix
left a comment
sdirix
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the contribution ❤️
Copy link
Member
sdirix
commented
Feb 19, 2024
sdirix commented
Feb 19, 2024@Maxouwell There is still some type error in the test, can you take a look?
Copy link
Contributor Author
Lookink into it
Copy link
Contributor Author
I can't reproduct the error on my side, I explicitly made the empty test array data an any[] type to look if it please jest
Copy link
coveralls
commented
Feb 19, 2024
coveralls commented
Feb 19, 2024
sdirix
merged commit
1d73eb7
into
eclipsesource:master
Maxouwell
deleted the
fix/material-array-layout-translated-no-data
branch
lucas-koehler
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants