dev: use the given i18n from the current example in vue vanilla example app by davewwww · Pull Request #2291 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
lucas-koehler merged 1 commit intoeclipsesource:masterfrom
Feb 20, 2024Merged
Conversation
Copy link
Contributor
davewwww
commented
Feb 19, 2024
davewwww
commented
As described here #2270 (review), the i18n key was not used in the example app to display the given translations.
Which led to the fact that here: https://deploy-preview-2270--jsonforms-examples.netlify.app/vue-vanilla/#categorization, no translation can be seen.
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 5f15b17 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/65d388731172bb00087d1f65 |
| 😎 Deploy Preview | https://deploy-preview-2291--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
sdirix approved these changes Feb 20, 2024
Copy link
Member
sdirix
left a comment
sdirix
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Copy link
coveralls
commented
Feb 20, 2024
coveralls commented
Feb 20, 2024
lucas-koehler
merged commit
e3bddec
into
eclipsesource:master
lucas-koehler
added this to the
3.3 milestone
lucas-koehler
added
dev
vanilla
vue
labels
davewwww
deleted the
fix/use-i18n-from-example
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment