Add tooltip for remove, up and down button on MaterialArrayLayout and MaterialArrayControl by Maxouwell · Pull Request #2295 · eclipsesource/jsonforms
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Maxouwell ,
thank you for this contribution ❤️
The code looks already pretty good to me and works as expected in the example app :)
I only have a few minor remarks inline. Please have a look.
Sorry, didn't see you commented on the PR !
I added the tooltip to the MaterialArrayControl to be coherent (Exemple site was nagging me).
I'm doing your comments
Maxouwell
changed the title
Add tooltip for remove, up and down button on MaterialArrayLayout
Add tooltip for remove, up and down button on MaterialArrayLayout and MaterialArrayControl
(should I be the one resolving the conversations ?)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Maxouwell , thanks for the updates and also updating the table control :)
You can resolve comments that you deem fixed in the future but I did it for now.
Maxouwell
deleted the
fix/mui-array-delete-button-tooltip
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters