React MUI : MaterialEnumArrayRenderer - Add Form Label and description by Maxouwell · Pull Request #2297 · eclipsesource/jsonforms
PR for #2296. with always on label (not conditionnal to an option)
…ce-enum-label-description
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Maxouwell , thanks a lot for another contribution ❤️
The code looks already pretty good to me and showing the labels and description works well in the example :)
I just have two small remarks inline. Please have a look.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks ✨
Maxouwell
deleted the
feature/mui-react-multi-choice-enum-label-description
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters