Add translation fix and support of elementLabelProp to ListWithDetail by Maxouwell · Pull Request #2304 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Maxouwell

Copy link

Contributor

@Maxouwell Maxouwell commented

Mar 20, 2024

edited

Loading

Based on #2289 PR

Fix some translation issues on MUI ListWithDetail component and add support for the elementLabelProp option (including translation of enum and oneOf values introduced by #2289)

@netlify

Copy link

netlify bot commented

Mar 20, 2024

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 13fa9c5
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66213fab9e0d670008a85021
😎 Deploy Preview https://deploy-preview-2304--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@Maxouwell Maxouwell changed the title Fix/list with details translated labels Add translation fix and support of elementLabelProp to ListWithDetail

Mar 20, 2024

@Maxouwell Maxouwell force-pushed the fix/ListWithDetails-translated-labels branch 2 times, most recently from 6d7e775 to 6303134 Compare

March 25, 2024 16:10

@coveralls

Copy link

coveralls commented

Mar 27, 2024

edited

Loading

Coverage Status

coverage: 83.347% (+0.08%) from 83.269%
when pulling 13fa9c5 on Maxouwell:fix/ListWithDetails-translated-labels
into a672127 on eclipsesource:master.

@Maxouwell Maxouwell marked this pull request as ready for review

April 18, 2024 15:09

@sdirix sdirix force-pushed the fix/ListWithDetails-translated-labels branch from 7ee0f71 to 187b614 Compare

April 18, 2024 15:14

@sdirix sdirix merged commit e1724a8 into eclipsesource:master

Apr 18, 2024

@Maxouwell Maxouwell deleted the fix/ListWithDetails-translated-labels branch

April 18, 2024 19:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Maxouwell @coveralls @sdirix