Home Original page

Angular 18 Update by lucas-koehler · Pull Request #2340 · eclipsesource/jsonforms

@lucas-koehler

Based on PR #2337 extended by using the Angular 18 release and regenerated pnpm lock file by me.

@netlify

@lucas-koehler

@laurentgrangier Please confirm whether JsonForms works for you with Angular 18 in this state. If yes, we'll merge this and do a release soon.

@coveralls

Coverage Status

coverage: 83.322% (-0.03%) from 83.347%
when pulling 70e26f8 on codeblock/feature/upgrade-angular-18
into 5c5a470 on master.

sdirix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the information about the angular upgrade in the migration document

@lucas-koehler

@sdirix Good point! I added a Json Forms 3.3 section mentioning this to MIGRATION.md

@laurentgrangier

@lucas-koehler Thank you for the new PR and the upgrade to Angular 18 final version. I check JsonForms with Angular 18 and give you feedback quickly (should be this week).

@laurentgrangier

@lucas-koehler I tested JSONForms built on this branch with our software using Angular 17 and also using Angular 18 and had no problem with JSONForms. We only use jsonforms/core and jsonforms/angular. No other packages of jsonforms.

sdirix

Updates code base to Angular 18. This removes support for Angular 16.

Also includes the following changes:

- removal of the angular test package
- Typescript update
- migration guide entry

Co-authored-by: Lucas Köhler <lkoehler@eclipsesource.com>

@sdirix sdirix deleted the codeblock/feature/upgrade-angular-18 branch

May 27, 2024 13:18

@sdirix

I also tested with React 18 in the Angular Seed application. That works 👍