Reduce bundle size by fixing material-icon imports by semery-fractalev · Pull Request #2351 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@semery-fractalev

Copy link

Contributor

* Reduce size of bundles by avoiding `import X from '@mui/icons-material'` style import statements
* Fixes eclipsesource#2350

@CLAassistant

Copy link

CLAassistant commented

Jul 3, 2024

edited

Loading

CLA assistant check
All committers have signed the CLA.

@netlify

Copy link

netlify bot commented

Jul 3, 2024

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 2581ebd
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/668559eee3c19b0008576b9f
😎 Deploy Preview https://deploy-preview-2351--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@sdirix

Copy link

Member

sdirix commented

Jul 3, 2024

Thank you very much! ❤️

@coveralls

Copy link

Coverage Status

coverage: 83.341% (+0.004%) from 83.337%
when pulling 2581ebd on semery-fractalev:fix/2350-icons-material-import-format
into c3cead7 on eclipsesource:master.

Copy link

Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 635faab into eclipsesource:master

Jul 3, 2024

@semery-fractalev semery-fractalev deleted the fix/2350-icons-material-import-format branch

July 3, 2024 17:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@mui/icons-material imports balloon bundle sizes

4 participants

@semery-fractalev @CLAassistant @sdirix @coveralls