fix the bug #2363 by changjung-kim · Pull Request #2368 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
sdirix merged 2 commits intoeclipsesource:masterfrom
changjung-kim:patch-to-fix-bug2363
Aug 21, 2024Merged
fix the bug #2363#2368
sdirix merged 2 commits intoeclipsesource:masterfrom
changjung-kim:patch-to-fix-bug2363
fix the bug #2363#2368
sdirix merged 2 commits intoeclipsesource:masterfrom
changjung-kim:patch-to-fix-bug2363
Conversation
Copy link
All committers have signed the CLA.
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | f450e2f |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/66c52293cc2faa0008043aff |
| 😎 Deploy Preview | https://deploy-preview-2368--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 2c4d35c |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/66c522a258ea2e00083aa3c8 |
| 😎 Deploy Preview | https://deploy-preview-2368--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
Contributor Author
changjung-kim
commented
Aug 20, 2024
changjung-kim commented
Aug 20, 2024Please review and merge this commit.
Copy link
coveralls
commented
Aug 21, 2024
coveralls commented
Aug 21, 2024sdirix approved these changes Aug 21, 2024
Copy link
Member
sdirix
left a comment
sdirix
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution ❤️
sdirix
merged commit
205ca9a
into
eclipsesource:master
changjung-kim
deleted the
patch-to-fix-bug2363
branch
sdirix
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants