fix incorrect code around markRaw invocation by kchobantonov · Pull Request #2379 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@kchobantonov

Copy link

Contributor

No description provided.

@netlify

Copy link

netlify bot commented

Sep 30, 2024

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 4215a6f
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66f9f1cdbb5e530008085558
😎 Deploy Preview https://deploy-preview-2379--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@kchobantonov

Copy link

Contributor Author

@sdirix can you please review

sdirix reacted with thumbs up emoji

@coveralls

Copy link

Coverage Status

coverage: 81.733%. remained the same
when pulling 4215a6f on kchobantonov:fix-markRaw
into 8c4b2f0 on eclipsesource:master.

Copy link

Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit d7f34b9 into eclipsesource:master

Sep 30, 2024

@sdirix sdirix added this to the 3.4.1 milestone

Sep 30, 2024

@sdirix sdirix added the vue label

Sep 30, 2024

@kchobantonov kchobantonov deleted the fix-markRaw branch

December 9, 2024 15:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@kchobantonov @coveralls @sdirix