Respect validationMode in React material table cells by 0mpurdy · Pull Request #2400 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
lucas-koehler merged 4 commits intoeclipsesource:masterfrom
Dec 5, 2024Merged
Respect validationMode in React material table cells#2400
lucas-koehler merged 4 commits intoeclipsesource:masterfrom
Respect validationMode in React material table cells#2400
lucas-koehler merged 4 commits intoeclipsesource:masterfrom
Conversation
Copy link
All committers have signed the CLA.
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 0038727 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/67509bc14e02b8000820a868 |
| 😎 Deploy Preview | https://deploy-preview-2400--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
Contributor Author
0mpurdy
commented
Nov 29, 2024
0mpurdy commented
Nov 29, 2024| Before | After |
|---|---|
 |
 |
0mpurdy commented Nov 29, 2024
packages/material-renderers/test/renderers/MaterialTableControl.test.tsx
Outdated
Show resolved
Hide resolved
packages/material-renderers/test/renderers/MaterialTableControl.test.tsx Outdated Show resolved Hide resolved
0mpurdy
force-pushed
the
validation-mode-cell-2398
branch
from
811073d to
d8371c2
Compare
sdirix
requested a review
from lucas-koehler
Copy link
Contributor
lucas-koehler
commented
Dec 4, 2024
lucas-koehler commented
Dec 4, 2024@0mpurdy Thanks for the contribution ❤️
The changes already look quite good to me. Please have a look at my answer to your comment #2400 (comment)
0mpurdy and others added 4 commits
December 4, 2024 18:12
0mpurdy
force-pushed
the
validation-mode-cell-2398
branch
from
d8371c2 to
0038727
Compare
Copy link
coveralls
commented
Dec 5, 2024
coveralls commented
Dec 5, 2024lucas-koehler approved these changes Dec 5, 2024
Copy link
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! Thanks for the contribution and all the tests ✨
lucas-koehler
merged commit
4a4e2ec
into
eclipsesource:master
sdirix
changed the title
React material table cell validationMode
Respect validationMode in React material table cells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants