fixes createDefaultValue doesn't follow anyOf, oneOf, allOf #2401 by kchobantonov · Pull Request #2402 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
sdirix merged 7 commits intoeclipsesource:masterfrom
Dec 6, 2024Merged
fixes createDefaultValue doesn't follow anyOf, oneOf, allOf #2401#2402
sdirix merged 7 commits intoeclipsesource:masterfrom
fixes createDefaultValue doesn't follow anyOf, oneOf, allOf #2401#2402
sdirix merged 7 commits intoeclipsesource:masterfrom
Conversation
Copy link
✅ Deploy Preview for jsonforms-examples ready!
| Name | Link |
|---|---|
| 🔨 Latest commit | 86bccc0 |
| 🔍 Latest deploy log | https://app.netlify.com/sites/jsonforms-examples/deploys/6753085f08e68f0008d5d0e9 |
| 😎 Deploy Preview | https://deploy-preview-2402--jsonforms-examples.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Copy link
Contributor Author
kchobantonov
commented
Dec 1, 2024
kchobantonov commented
Dec 1, 2024@sdirix check the fixed example here https://deploy-preview-2402--jsonforms-examples.netlify.app/react-material/#anyOf
sdirix requested changes Dec 5, 2024
Copy link
Member
sdirix
left a comment
sdirix
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sdirix check the fixed example here https://deploy-preview-2402--jsonforms-examples.netlify.app/react-material/#anyOf
I don't see any difference in the example between master and this PR
packages/core/src/mappers/renderer.ts
Outdated
Show resolved
Hide resolved
packages/core/src/mappers/renderer.ts Outdated Show resolved Hide resolved
packages/core/src/mappers/renderer.ts
Outdated
Show resolved
Hide resolved
packages/core/src/mappers/renderer.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author
kchobantonov
commented
Dec 5, 2024
kchobantonov commented
Dec 5, 2024@sdirix check the fixed example here https://deploy-preview-2402--jsonforms-examples.netlify.app/react-material/#anyOf
I don't see any difference in the example between
masterand this PR
this is how it looks without the fix
and this is how it looks with the fix
kchobantonov and others added 2 commits
December 5, 2024 11:28
kchobantonov
requested a review
from sdirix
Copy link
Contributor Author
kchobantonov
commented
Dec 5, 2024
kchobantonov commented
Dec 5, 2024@sdirix please review again
sdirix reviewed Dec 5, 2024
packages/core/src/mappers/renderer.ts
Outdated
Show resolved
Hide resolved
packages/core/src/mappers/renderer.ts Outdated Show resolved Hide resolved
kchobantonov added 2 commits
December 5, 2024 13:51
kchobantonov
requested a review
from sdirix
sdirix approved these changes Dec 6, 2024
Copy link
coveralls
commented
Dec 6, 2024
coveralls commented
Dec 6, 2024
sdirix
merged commit
576d9e0
into
eclipsesource:master
sdirix
mentioned this pull request
kchobantonov
deleted the
fix-createDefaultValue
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants