added timeouts to socks5 connection initialization by Brranton · Pull Request #1017 · encode/httpcore

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Brranton

Copy link

@Brranton Brranton commented

Jun 6, 2025

edited

Loading

Summary

added timeouts to socks5 connection initialization

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
HansBrende and kotori2 reacted with hooray emoji

Brranton added 5 commits

June 6, 2025 17:45
set timeouts for socks5 connection initialization
changed annotation type
Fixed a typo in “typle”
added timeouts for socks5 connection initialization in _async\socks_proxy.py
function _init_socks5_connection is reformatted

@Brranton

Copy link

Author

Brranton commented

Jun 6, 2025

this fixes issue #1015

@dmittov

Copy link

dmittov commented

Aug 6, 2025

Thanks! I faced this issue today.
Socks proxy doesn't respond and the code stuck on awaiting stream.read much longer than I expected passing the explicit timeout to the request.

I hope this fix is merges soon. Looking forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Brranton @dmittov