added timeouts to socks5 connection initialization by Brranton · Pull Request #1017 · encode/httpcore
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 148
Open
added timeouts to socks5 connection initialization#1017
Brranton wants to merge 5 commits intoencode:masterfrom
added timeouts to socks5 connection initialization#1017
Brranton wants to merge 5 commits intoencode:masterfrom
Conversation
Copy link
Summary
added timeouts to socks5 connection initialization
Checklist
- I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
- I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
- I've updated the documentation accordingly.
Brranton added 5 commits
June 6, 2025 17:45set timeouts for socks5 connection initialization
changed annotation type
Fixed a typo in “typle”
added timeouts for socks5 connection initialization in _async\socks_proxy.py
function _init_socks5_connection is reformatted
Copy link
Author
Brranton
commented
Jun 6, 2025
Brranton commented
Jun 6, 2025this fixes issue #1015
Copy link
dmittov
commented
Aug 6, 2025
dmittov commented
Aug 6, 2025Thanks! I faced this issue today.
Socks proxy doesn't respond and the code stuck on awaiting stream.read much longer than I expected passing the explicit timeout to the request.
I hope this fix is merges soon. Looking forward.
drshvik
mentioned this pull request
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment