Various String handling cleanups by dirkmueller · Pull Request #6945 · esp8266/Arduino
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 13.2k
Merged
devyte merged 1 commit intoesp8266:masterfrom
Dec 26, 2019Merged
Various String handling cleanups#6945
devyte merged 1 commit intoesp8266:masterfrom
Various String handling cleanups#6945
devyte merged 1 commit intoesp8266:masterfrom
Conversation
Copy link
Contributor
dirkmueller
commented
Dec 25, 2019
dirkmueller
commented
Use the proper api (::clear(), isEmpty()) instead of doing
comparisons/assignments of empty strings. Also fix mixture
of tabs and spaces in the source code.
dirkmueller
force-pushed
the
string_fixes
branch
from
10d6b2c to
019d0cc
Compare
Use the proper api (::clear(), isEmpty()) instead of doing comparisons/assignments of empty strings. Also fix mixture of tabs and spaces in the source code.
dirkmueller
force-pushed
the
string_fixes
branch
from
019d0cc to
8e7a78c
Compare
devyte approved these changes Dec 26, 2019
Copy link
Collaborator
devyte
left a comment
devyte
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of cleanup is always welcome!
devyte
merged commit
698ffc3
into
esp8266:master
devyte
added this to the
2.7.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment