self-requested a review

dirkmueller changed the title Fix length overflow in username/password authentication Fix integer length overflow in basic auth

dirkmueller added a commit to dirkmueller/Arduino that referenced this pull request

This is a followup of the discussion in
esp8266#6946 (comment)

to untangle the namespace/double inclusions in this library.

d-a-v pushed a commit that referenced this pull request

untangle the namespace/double inclusions in webserver library.
This is a followup of the discussion in
#6946 (comment)

The string lengths were added and then stored in "char" which is
limited in values at most up to 255. Using size_t is a much more
appropriate type.

In addition the code was using base64 with newlines injected
(easy to fall into that trap as the default is imho wrong), which
means that anything longer than ~ 60 characters never matched and
you had no way to authenticate against the server.