Updating _port to really used port and made _port accessible by LaborEtArs · Pull Request #7003 · esp8266/Arduino
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 13.2k
Merged
devyte merged 2 commits intoesp8266:masterfrom
Jan 9, 2020Merged
Updating _port to really used port and made _port accessible#7003
devyte merged 2 commits intoesp8266:masterfrom
Updating _port to really used port and made _port accessible#7003
devyte merged 2 commits intoesp8266:masterfrom
Conversation
Copy link
Contributor
LaborEtArs
commented
Jan 8, 2020
LaborEtArs
commented
When calling WiFiServer with a 'port = 0', a free port is auto-selected, but this port isn't updated to the '_port' member. In addition, the used port is made accessible.
Copy link
Collaborator
d-a-v
commented
Jan 8, 2020
d-a-v commented
Jan 8, 2020Thanks, but you added submodules in this PR.
Can you remove them ?
(probably with git checkout upstream/master -- libraries/LittleFS/lib/littlefs (and libraries/SoftwareSerial and tools/sdk/ssl/bearssl)
Copy link
Contributor Author
LaborEtArs
commented
Jan 8, 2020
LaborEtArs commented
Jan 8, 2020Those submodules were automagically added by git when I created the branch... will try to remove them though...
Copy link
Contributor Author
Tried the 'git checkout upstream/master -- libraries/LittleFS/lib/littlefs', ... from my point of view it hadn't helped, or?? Really love this 'git'-stuff......
d-a-v approved these changes Jan 8, 2020
Copy link
Collaborator
d-a-v
commented
Jan 8, 2020
d-a-v commented
Jan 8, 2020Apparently it did help
Copy link
Contributor Author
LaborEtArs
commented
Jan 8, 2020
LaborEtArs commented
Jan 8, 2020Wow, thanks for your help!
devyte approved these changes Jan 9, 2020
devyte
merged commit
5e537e5
into
esp8266:master
devyte
added
component: core
type: bug
type: enhancement
labels
d-a-v
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment