Updated stack offsets for postmortem stack dump. by mhightower83 · Pull Request #7066 · esp8266/Arduino
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 13.2k
Merged
earlephilhower merged 1 commit intoesp8266:masterfrom
Feb 8, 2020Merged
Updated stack offsets for postmortem stack dump.#7066
earlephilhower merged 1 commit intoesp8266:masterfrom
Updated stack offsets for postmortem stack dump.#7066
earlephilhower merged 1 commit intoesp8266:masterfrom
Conversation
Copy link
Contributor
mhightower83
commented
Feb 7, 2020
mhightower83
commented
Changed ets_putc to ets_uart_putc1 to better newline handling.
Changed ets_putc to ets_uart_putc1 to better newline handling.
mhightower83
requested a review
from d-a-v
earlephilhower approved these changes Feb 8, 2020
Copy link
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've restarted the build since the failure looked like transient network issues.
earlephilhower
merged commit
50a491b
into
esp8266:master
mhightower83
deleted the
pr-postmortem-offset-update
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants