settimeofday_cb: distinguish from user or sntp by d-a-v · Pull Request #7637 · esp8266/Arduino
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 13.2k
Merged
d-a-v merged 5 commits intoesp8266:masterfrom
Oct 23, 2020Merged
settimeofday_cb: distinguish from user or sntp#7637
d-a-v merged 5 commits intoesp8266:masterfrom
settimeofday_cb: distinguish from user or sntp#7637
d-a-v merged 5 commits intoesp8266:masterfrom
Conversation
Copy link
Collaborator
This PR overrides settimeofday_cb() with a new callback signature:
- currently
void myCB ()is and remains accepted void myBetterCB (bool from_sntp)is added:from_sntpis true when time is set by SNTP, otherwise it is false.
Consequently:
- lwip2 is updated with a trivial change
- NTP_TZ_DST example is also updated to show this new callback
Fixes #7616 @JakubRakus
Copy link
JakubRakus
commented
Oct 16, 2020
JakubRakus commented
Oct 16, 2020Tested, works like a charm.
d-a-v and others added 3 commits
October 16, 2020 14:54earlephilhower approved these changes Oct 21, 2020
Copy link
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d-a-v
merged commit
95fb104
into
esp8266:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment