String: compatibility with 64 bits scalars by d-a-v · Pull Request #7863 · esp8266/Arduino

@d-a-v

time_t is now 64 bits.
This PR resolves String(time_t) ambiguity.

time_t is now 64 bits. Strig(time_t) was ambiguous
tests added

@d-a-v

@d-a-v

@d-a-v

earlephilhower

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@earlephilhower

mcspr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-a-v

@d-a-v

@mcspr I tried with charconv that I didn't know. That's very handy !
That one is faster (1.6x) but has a cost (+880B/flash+256B/rodata) (compared against lltoa)*
It has to be noted that these functions charconv(std::to_chars) or lltoa are used only when radix is not 10 (in which case sprintf is used). It should be quite rare.
Without further comments, I will push a newer commit keeping only lltoa. These functions will anyway not be linked in the general case.

earlephilhower

@d-a-v d-a-v mentioned this pull request

Feb 19, 2021