Add writeToPrint to ESP8266HTTPClient by TheNitek · Pull Request #8056 · esp8266/Arduino
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 13.2k
Merged
earlephilhower merged 3 commits intoesp8266:masterfrom
Sep 4, 2021Merged
Add writeToPrint to ESP8266HTTPClient#8056
earlephilhower merged 3 commits intoesp8266:masterfrom
Add writeToPrint to ESP8266HTTPClient#8056
earlephilhower merged 3 commits intoesp8266:masterfrom
Conversation
Copy link
Contributor
TheNitek
commented
May 19, 2021
TheNitek
commented
Currently ESP8266HTTPClient only has writeToStream(Stream ), but interally only uses the Stream as a Print*. Since Print* is more lightweight, adding a writeToPrint(Print *) seems to make sense. E.g. this allows to use SdFile directly.
wirteToStream is kept for backward compatibility
TheNitek and others added 2 commits
May 19, 2021 20:41d-a-v approved these changes May 22, 2021
Copy link
Collaborator
d-a-v
left a comment
d-a-v
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
d-a-v
added this to the
3.1 milestone
earlephilhower approved these changes Sep 4, 2021
earlephilhower
merged commit
140d0ff
into
esp8266:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment