platformio: use CCFLAGS for -Werror by mcspr · Pull Request #8175 · esp8266/Arduino

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mcspr

Copy link

Collaborator

@mcspr mcspr commented

Jun 25, 2021

Fixup #8165, as it only changed behaviour for .c files

Also adds some comments referencing SCons documentation (literally)

Also adds some comments referencing SCons documentation
Copy link

Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and adding comments so it's unlikely to happen again!

@earlephilhower earlephilhower added this to the 3.0.1 milestone

Jun 26, 2021

@earlephilhower earlephilhower merged commit 019fab4 into esp8266:master

Jun 26, 2021

@mcspr mcspr deleted the patch-1 branch

June 26, 2021 12:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@mcspr @earlephilhower