DHCP custom option by mcspr · Pull Request #8582 · esp8266/Arduino
added 2 commits
May 27, 2022 11:11
mcspr
mentioned this pull request
/to d-a-v it has automatic storage, here it's the same stack based one (just one less line for us)
mcspr
marked this pull request as ready for review
mcspr
deleted the
dhcps-opts
branch
mcspr added a commit to mcspr/esp8266-Arduino that referenced this pull request
Jun 14, 2022
As noticed in esp8266#8582 (comment) Can't really use `server.begin()` and `server.end()` directly, only default static IP is applied to the interface since DHCP server is deemed 'running' (see `wifi_softap_dhcps_status()` return value)
mcspr
mentioned this pull request
mcspr added a commit that referenced this pull request
Jun 27, 2022
* Fix sending NACK, use helper function to fill pbuf As noticed in #8582 (comment) Plus, handle the case when `pbuf->len` is less than struct size * Make sure to call SDK functions to start and stop DHCP server As noticed in #8582 (comment) Can't really use `server.begin()` and `server.end()` directly, only default static IP is applied to the interface since DHCP server is deemed 'running' (see `wifi_softap_dhcps_status()` return value) * s Co-authored-by: david gauchard <gauchard@laas.fr>
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request
Nov 18, 2024
* works * fixup! works * back to callbacks * names * daisy chain * seconds * less inline * fix dns setter * might as well keep using initlist /to d-a-v it has automatic storage, here it's the same stack based one (just one less line for us) * shift blame * naming * fix impl * revert to ip4 dns * merge fix * restyle * masking done wrong
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request
Nov 18, 2024…266#8602) * Fix sending NACK, use helper function to fill pbuf As noticed in esp8266#8582 (comment) Plus, handle the case when `pbuf->len` is less than struct size * Make sure to call SDK functions to start and stop DHCP server As noticed in esp8266#8582 (comment) Can't really use `server.begin()` and `server.end()` directly, only default static IP is applied to the interface since DHCP server is deemed 'running' (see `wifi_softap_dhcps_status()` return value) * s Co-authored-by: david gauchard <gauchard@laas.fr>
ttschnz pushed a commit to ttschnz/ESP8266Wifi that referenced this pull request
Oct 4, 2025
* Fix sending NACK, use helper function to fill pbuf As noticed in esp8266/Arduino#8582 (comment) Plus, handle the case when `pbuf->len` is less than struct size * Make sure to call SDK functions to start and stop DHCP server As noticed in esp8266/Arduino#8582 (comment) Can't really use `server.begin()` and `server.end()` directly, only default static IP is applied to the interface since DHCP server is deemed 'running' (see `wifi_softap_dhcps_status()` return value) * s Co-authored-by: david gauchard <gauchard@laas.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters