👌 IMPROVE: Allow for opening external links in new tabs (#856) by marjuscako · Pull Request #857

👌 IMPROVE: Allow for opening external links in new tabs (#856) by marjuscako · Pull Request #857 · executablebooks/MyST-Parser

Add support to enable external links to open in a new tab. Expose the configuration option myst_links_external_new_tab, which if set will set all URL links to open in a new tab on the browser.

Besides that, we allow the user to set the target and rel attributes when using the extension inline_attrs (#820).

Closes #820
Closes #856

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support to enable external links to open in a new tab. Expose the
configuration option myst_links_external_new_tab, which if set will set
all URL links to open in a new tab on the browser.

Besides that, we allow the user to set the target and rel attributes
when using the extension inline_attrs (executablebooks#820).

Closes executablebooks#820
Closes executablebooks#856

Signed-off-by: Marjus Cako <marios.cako@hpe.com>

Thanks a lot for the pointer @chrisjsewell . I updated my commit with a couple of tests for these features. Please let me know if that will suffice!

chrisjsewell changed the title ~~👌 IMPROVE: External links in new tab (#856)~~ 👌 IMPROVE: Allow for opening external links in new tabs (#856)

Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (abcc087) to head (06a63f3).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   90.09%   90.10%   +0.01%     
==========================================
  Files          24       24              
  Lines        3372     3377       +5     
==========================================
+ Hits         3038     3043       +5     
  Misses        334      334

Flag	Coverage Δ
pytests	`90.10% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great cheers!

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

chrisjsewell added a commit to sphinx-doc/sphinx that referenced this pull request

Jun 28, 2024