use pathlib by danieleades · Pull Request #864 · executablebooks/MyST-Parser

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@danieleades

Copy link Copy Markdown

Contributor

No description provided.

@codecov-commenter

Copy link Copy Markdown

codecov-commenter commented

Mar 26, 2024

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (e74769c) to head (cb24054).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          24       24           
  Lines        3372     3372           
=======================================
  Hits         3037     3037           
  Misses        335      335           
Flag Coverage Δ
pytests 90.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell

Copy link Copy Markdown

Member

heya @danieleades do you wanna fix the last few lints?:

myst_parser/inventory.py:410:10: PTH123 `open()` should be replaced by `Path.open()`
myst_parser/inventory.py:471:14: PTH123 `open()` should be replaced by `Path.open()`
myst_parser/mdit_to_docutils/base.py:1211:17: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator
myst_parser/mdit_to_docutils/sphinx_.py:68:17: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danieleades @codecov-commenter @chrisjsewell