Update version file and add tests by katmpatz · Pull Request #1393

Update version file and add tests by katmpatz · Pull Request #1393 · exercism/java

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @katmpatz! Only one minor indentation issue 🙂

		@Test
		public void test49ToRomanNumberXLIX() {
		romanNumeral = new RomanNumeral(49);
		assertEquals("XLIX", romanNumeral.getRomanNumeral());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here appears to be a bit inconsistent. I think the four statements above need to be indented with one more space 🙂

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!! I will fix it! 😄

katmpatz changed the title ~~Update version file and add tests~~ Update version file and add tests

Apr 11, 2018

I uploaded by mistake the solve of issue #1393 in this pull request. I am new to github and I am not used to git commands. Should I have to make a new pull request for this issue? Thank you for understanding!

Yes, please only fix one issue per pull request. To make that easier it's a good idea to make a branch for each issue you start working on. Once you've pushed that branch and opened a pull request for it you can checkout master and make a new branch for the next issue you want to work on 🙂

Does that make sense? 🙂 I know git and github can be confusing at first so let us know if you need any help 🙂

Ok I will do that! Thank you for the advice!! 😄

No problem, that's what we're here for 🙂