update homepage link http to https by bjohansebas · Pull Request #5920 · expressjs/express
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 22.6k
Comments
Merged
UlisesGascon merged 2 commits intoexpressjs:masterfrom
Oct 20, 2024Merged
update homepage link http to https#5920
UlisesGascon merged 2 commits intoexpressjs:masterfrom
update homepage link http to https#5920
UlisesGascon merged 2 commits intoexpressjs:masterfrom
Conversation
Copy link
Member
bjohansebas
commented
Sep 8, 2024
bjohansebas
commented
It would be good to use HTTPS for the homepage link.
IamLizu approved these changes Sep 8, 2024
wesleytodd approved these changes Sep 9, 2024
UlisesGascon approved these changes Sep 10, 2024
Copy link
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch @bjohansebas!
Copy link
Member Author
bjohansebas
commented
Sep 10, 2024
bjohansebas commented
Sep 10, 2024Should I update the branch?
Copy link
Member
wesleytodd
commented
Sep 10, 2024
wesleytodd commented
Sep 10, 2024You can, but until we merge 5.x we are frozen on master anyway. I just have not been able to get to it today with dentists appts and work stuff.
bjohansebas
changed the base branch from
5.0
to
master
Copy link
Member
UlisesGascon
commented
Oct 20, 2024
UlisesGascon commented
Oct 20, 2024condition meet, I will merge the PR
UlisesGascon
merged commit
b274047
into
expressjs:master
bjohansebas
deleted the
use-https
branch
UlisesGascon
mentioned this pull request
Closed
wesleytodd
mentioned this pull request
Merged
This was referenced
Aug 15, 2025This was referenced
Aug 24, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants