fix(buffer): use node:buffer instead of safe-buffer by bhavya3024 · Pull Request #6071

fix(buffer): use node:buffer instead of safe-buffer by bhavya3024 · Pull Request #6071 · expressjs/express

Conversation

Since express@5 will support minimum of nodejs version 18, I think it would be safe to use node:buffer .
Also I didn't see any new Buffer usage anywhere in their repo.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I would say is this is not a "chore" commit. It is a fix or feat (honestly in this case I could see it going either way) and also the "scope" section here is not really necessary. Not a big deal since we don't really enforce the conventional commit conventions anyway, but just figured I would drop this note with the approval in case you wanted to edit it before we merge.

bhavya3024 changed the title ~~chore(buffer): use node:buffer instead of safe-buffer~~ fix(buffer): use node:buffer instead of safe-buffer

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Labels