cleanup: remove promise support check from tests by Phillip9587 · Pull Request #6148 · expressjs/express

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Comments

Conversation

@Phillip9587

Copy link

Member

Promises are supported in all supported Node.js version so the check is unnecessary

Promises are supported in all supported Node.js version so the check is unnecessary

@wesleytodd wesleytodd merged commit 9e3dbb4 into expressjs:master

Nov 12, 2024

@Phillip9587 Phillip9587 deleted the remove-promise-check branch

November 12, 2024 15:42

@bjohansebas bjohansebas mentioned this pull request

Mar 15, 2025

@UlisesGascon UlisesGascon mentioned this pull request

Mar 23, 2025

68 tasks

@wesleytodd wesleytodd mentioned this pull request

Mar 28, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinusU LinusU LinusU approved these changes

@wesleytodd wesleytodd wesleytodd approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Phillip9587 @LinusU @wesleytodd @UlisesGascon @bjohansebas