fix: usage of `Invalid action input 'persist-credentials'` for `actions/setup-node@v4` in `ci.yml` by hamirmahal · Pull Request #6256 · expressjs/express
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 22.6k
Comments
Merged
fix: usage of Invalid action input 'persist-credentials' for actions/setup-node@v4 in ci.yml#6256
wesleytodd merged 1 commit intoexpressjs:masterfrom
hamirmahal:master
fix: usage of Invalid action input 'persist-credentials' for actions/setup-node@v4 in ci.yml#6256
wesleytodd merged 1 commit intoexpressjs:masterfrom
hamirmahal:master
Conversation
hamirmahal commented Jan 3, 2025
Copy link
Contributor Author
hamirmahal
left a comment
hamirmahal
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks passed when I ran this on my fork.
wesleytodd requested changes Jan 8, 2025
Copy link
Member
wesleytodd
left a comment
wesleytodd
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the unrelated changes which have been made to this file and then we can run the actions on the PR.
wesleytodd
mentioned this pull request
hamirmahal
requested a review
from wesleytodd
wesleytodd approved these changes Jan 8, 2025
bjohansebas approved these changes Jan 13, 2025
bjohansebas
mentioned this pull request
Closed
wesleytodd
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants