refactor: use cached slice in app.listen by Tacit1 · Pull Request #6897 · expressjs/express
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 22.6k
Comments
Merged
bjohansebas merged 1 commit intoexpressjs:masterfrom
Nov 23, 2025Merged
refactor: use cached slice in app.listen#6897
bjohansebas merged 1 commit intoexpressjs:masterfrom
refactor: use cached slice in app.listen#6897
bjohansebas merged 1 commit intoexpressjs:masterfrom
Conversation
Copy link
Contributor
Tacit1
commented
Nov 16, 2025
Tacit1
commented
Use the existing slice variable instead of Array.prototype.slice for consistency and to avoid repeated property lookups.
No behavior change. All tests pass. Linting clean.
Closes #6896
Signed-off-by: Tacit1 <tacitim5@gmail.com>
efekrskl
mentioned this pull request
bjohansebas approved these changes Nov 23, 2025
Copy link
Member
bjohansebas
left a comment
bjohansebas
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
UlisesGascon
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants