feat: help popup display viewing progress by wugeer · Pull Request #2388 · gitui-org/gitui

Conversation

@wugeer

It changes the following:

  • help popiup page show viewing progress

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

before
gitui_help_popup_before.webm

after
gitui_help_popup_after.webm

@extrawurst

Thanks for looking into this. The gitui idiomatic way to show progress on a vertical scroll though is using a scrollbar. so I would suggest we integrate that here too. feel free to join our discord to discuss there things upfront in the future to not waste any effort.

@wugeer

In my personal view, having a percentage-based progress might make it a bit easier to understand. :)
It seems that when scrolling up and down on this page, I didn’t notice a scrollbar on the right side.
image
Also, I’ll create a Discord account a bit later.

@wugeer

@extrawurst I'll try to add a scrollbar on the right, similar to the one in a browser.:)

@extrawurst

Browser?

Just use the same code we use everywhere else do scroll bars in for example the log tab

@wugeer

Yes, I will try it. :)
image

@wugeer

@extrawurst

looking good! i wonder why you have different formatting - lets see what the ci says about that

edit: it fails on the formatting. please make sure to use the latest rust stable

@wugeer

My bad, my local environment was on an unstable version. I switched to the stable version of Rust, and cargo clippy works fine.

@extrawurst

Thanks for your contribution

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Jan 28, 2025

2 participants

@wugeer @extrawurst