feat: help popup display viewing progress by wugeer · Pull Request #2388 · gitui-org/gitui
Conversation
It changes the following:
- help popiup page show viewing progress
I followed the checklist:
- I added unittests
- I ran
make checkwithout errors - I tested the overall application
- I added an appropriate item to the changelog
before
gitui_help_popup_before.webm
Thanks for looking into this. The gitui idiomatic way to show progress on a vertical scroll though is using a scrollbar. so I would suggest we integrate that here too. feel free to join our discord to discuss there things upfront in the future to not waste any effort.
@extrawurst I'll try to add a scrollbar on the right, similar to the one in a browser.:)
looking good! i wonder why you have different formatting - lets see what the ci says about that
edit: it fails on the formatting. please make sure to use the latest rust stable
My bad, my local environment was on an unstable version. I switched to the stable version of Rust, and cargo clippy works fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

