Home Original page

Fix for #6720: HMR not working in Firefox if proxy option present by dmile · Pull Request #7444 · facebook/create-react-app

@dmile

@mrmckeb @dmile

This was referenced

Jul 28, 2019

@dmile

mrmckeb

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide testing criteria for this please @dmile?

[Edit] A test repository would actually be ideal.

@iansu can I get your thoughts on this?

@dmile

@dmile

Can you provide testing criteria for this please @dmile?

[Edit] A test repository would actually be ideal.

Testing is pretty simple, not sure that special repository needed:

  1. Add a proxy field to your package.json, for example: "proxy": "http://localhost:4000"
  2. Run the app in the development mode. Open http://localhost:3000 to view it in the Firefox.

Errors like:

  • The development server has disconnected ... in browser console
  • Proxy error: Could not proxy request /sockjs-node/947/wwr0adlx/websocket from localhost:3000 to http://localhost:4000 ... in app console (if you make code edits)

should disappear

patilharshal16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hard-coded path is a good approach?

@dmile

patilharshal16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case you need to check for platform compatibility for this path.

@dmile

iansu

@lock lock bot locked and limited conversation to collaborators

Aug 12, 2019