Home Original page

Remove custom header support from DevSupportHttpClient by cortinico · Pull Request #55884 · facebook/react-native

@meta-cla bot added the CLA Signed

This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

label

Mar 3, 2026

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:
Pull Request resolved: facebook#55884

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:
Pull Request resolved: facebook#55884

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:
Pull Request resolved: facebook#55884

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080

cortinico added a commit to cortinico/react-native that referenced this pull request

Mar 4, 2026 
Summary:
Pull Request resolved: facebook#55884

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080
Summary:

All 7 callers of DevSupportHttpClient are within ReactAndroid, so
there is no need to expose it as a public API. Make the class and all
its members internal.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D95059038
Summary:

The addRequestHeader/removeRequestHeader methods don't need to live inside devsupport.

Instead we can use the `setOkHttpClientFactory` to provide this same logic.

Changelog: [Internal]

Reviewed By: javache, cipolleschi

Differential Revision: D95059080