Home Original page

feature: add support for constant values by robertadkins · Pull Request #1835 · ferdikoomen/openapi-typescript-codegen

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@robertadkins

Copy link Copy Markdown

Closes #1834

See the issue above for a description of a usecase where support for the const keyword is useful. Updated the snapshot tests to verify correct output.

vmlopezr and nicolas-chaulet reacted with heart emoji josh-hemphill, kovalewvladimir, bbonsign, and hinaloe reacted with eyes emoji

@robertadkins robertadkins marked this pull request as ready for review

October 14, 2023 00:35

@robertadkins

Copy link Copy Markdown

Author

Since const was added in OpenAPI v3.1 (see discussion in #1834), updating this PR to only modify the v3 parsing and tests.

@mrlubos

Copy link Copy Markdown

Collaborator

mrlubos commented

Jan 28, 2024

@robertadkins we've decided to merge this pull request in our fork, thanks for this feature!

robertadkins and kovalewvladimir reacted with heart emoji

@kovalewvladimir

Copy link Copy Markdown

@robertadkins we've decided to merge this pull request in our fork, thanks for this feature!

Thank you. It really works in the fork.

@mrlubos

Copy link Copy Markdown

Collaborator

mrlubos commented

Feb 21, 2024

@kovalewvladimir are there any other issues you're running into with this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for const keyword

3 participants

@robertadkins @mrlubos @kovalewvladimir