feat: extract routes from example app to main library by Lyokone · Pull Request #2246 · firebase/FirebaseUI-Android
Navigation Menu
{{ message }}
firebase / FirebaseUI-Android Public
- Notifications You must be signed in to change notification settings
- Fork 1.9k
Merged
feat: extract routes from example app to main library#2246
demolaf merged 5 commits intoversion-10.0.0-devfrom
feat: extract routes from example app to main library#2246
demolaf merged 5 commits intoversion-10.0.0-devfrom
Conversation
Copy link
Contributor
Lyokone
commented
Oct 21, 2025
Lyokone
commented
Currently some of the routing was only done in the example app.
We have now properly moved the logic inside the main library.
Lyokone added 4 commits
October 21, 2025 13:57demolaf reviewed Oct 22, 2025
auth/src/main/java/com/firebase/ui/auth/compose/ui/screens/FirebaseAuthScreen.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/compose/ui/screens/FirebaseAuthScreen.kt Outdated Show resolved Hide resolved
demolaf reviewed Oct 22, 2025
composeapp/src/main/java/com/firebase/composeapp/MainActivity.kt
Show resolved
Hide resolved
composeapp/src/main/java/com/firebase/composeapp/MainActivity.kt Show resolved Hide resolved
demolaf reviewed Oct 22, 2025
auth/src/main/java/com/firebase/ui/auth/compose/ui/screens/FirebaseAuthScreen.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/compose/ui/screens/FirebaseAuthScreen.kt Outdated Show resolved Hide resolved
demolaf reviewed Oct 22, 2025
auth/src/main/java/com/firebase/ui/auth/compose/ui/screens/FirebaseAuthScreen.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/compose/ui/screens/FirebaseAuthScreen.kt Outdated Show resolved Hide resolved
demolaf reviewed Oct 22, 2025
auth/src/main/java/com/firebase/ui/auth/compose/ui/screens/FirebaseAuthScreen.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/compose/ui/screens/FirebaseAuthScreen.kt Outdated Show resolved Hide resolved
demolaf approved these changes Oct 22, 2025
Copy link
Member
demolaf
left a comment
demolaf
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants