fix: use .equals() instead of == for strings by yanikapitanov · Pull Request #1065 · firebase/firebase-admin-java
Navigation Menu
{{ message }}
firebase / firebase-admin-java Public
- Notifications You must be signed in to change notification settings
- Fork 306
Merged
jonathanedey merged 1 commit intofirebase:masterfrom
Jan 28, 2025Merged
fix: use .equals() instead of == for strings#1065
jonathanedey merged 1 commit intofirebase:masterfrom
fix: use .equals() instead of == for strings#1065
jonathanedey merged 1 commit intofirebase:masterfrom
Conversation
Copy link Copy Markdown
Contributor
yanikapitanov
commented
Jan 25, 2025
yanikapitanov
commented
Simple fix for string comparison.
From what I could see these changes are already covered by unit tests and I was not sure how to add new ones to test this specific scenario.
jonathanedey
self-requested a review
jonathanedey approved these changes Jan 28, 2025
Copy link Copy Markdown
Collaborator
jonathanedey
left a comment
jonathanedey
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @yanikapitanov!
As for testing we will add a follow up PR with updated tests.
jonathanedey
mentioned this pull request
jonathanedey
added
the
release-note
label
jonathanedey
merged commit
dcd8b9e
into
firebase:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment