Home Original page

feat(fcm): Support `proxy` field in FCM `AndroidNotification` by vitvvv1 · Pull Request #1084 · firebase/firebase-admin-java

@vitvvv1

@vitvvv1

chong-shao

jonathanedey

Comment on lines +212 to +213

public enum Proxy {
PROXY_UNSPECIFIED,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove PROXY_UNSPECIFIED and have the absence of the field be enough to show it's not specified.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROXY_UNSPECIFIED is removed.

Thanks for the feedback.

@vitvvv1

jonathanedey

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vitvvv1 for your contribution!
Looks good, added one more comment. Could you also resolve the lint error blocking tests.

@jonathanedey jonathanedey changed the title add 'proxy' to AndroidNotification feat(fcm): Support proxy field in FCM AndroidNotification

Mar 17, 2025

OrlandriaH-G

@vitvvv1 @jonathanedey 

…n.java


fix comment AndroidNotification.setProxy

Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com>