Add subtitle in ApsAlert by chemidy · Pull Request #219 · firebase/firebase-admin-java
Navigation Menu
{{ message }}
firebase / firebase-admin-java Public
- Notifications You must be signed in to change notification settings
- Fork 306
Merged
hiranya911 merged 8 commits intofirebase:masterfrom
chemidy:aps-subtitle
hiranya911 merged 8 commits intofirebase:masterfrom
chemidy:aps-subtitle
Conversation
Copy link Copy Markdown
Contributor
chemidy
commented
Nov 23, 2018
chemidy
commented
Add subtitle field in ApsAlert payload + tests
chemidy added 7 commits
November 23, 2018 18:04hiranya911 suggested changes Nov 26, 2018
Copy link Copy Markdown
Contributor
hiranya911
left a comment
hiranya911
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one additional test case required for completeness.
src/test/java/com/google/firebase/messaging/MessageTest.java
Show resolved
Hide resolved
src/test/java/com/google/firebase/messaging/MessageTest.java Show resolved Hide resolved
hiranya911
self-assigned this
hiranya911 approved these changes Nov 27, 2018
Copy link Copy Markdown
Contributor
hiranya911
left a comment
hiranya911
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hiranya911
merged commit
3bade2b
into
firebase:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants