Home Original page

feat(fcm): Add FcmOptions on MulticastMessage by pavlospt · Pull Request #439 · firebase/firebase-admin-java

Conversation

hiranya911

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pavlospt. Looks mostly good. Just a couple of updates needed.

@hiranya911 hiranya911 changed the title Add FcmOptions on MulticastMessage feat(fcm): Add FcmOptions on MulticastMessage

Jun 9, 2020

@pavlospt

Thanks for the PR @pavlospt. Looks mostly good. Just a couple of updates needed.

Hey @hiranya911 thank you for your review. I have updated the PR accordingly 😄 !

hiranya911

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@pavlospt pavlospt deleted the feature/multicase-message-fcm-options branch

June 9, 2020 19:58

@pavlospt

@hiranya911 Sorry for the question, but since this is a thing we will be needing ASAP, I feel like I need to ask 😂 . Do we know when we can have a release including it? 😄

@hiranya911

@pavlospt we can try to get a release out next week.

@pavlospt

@pavlospt

Hey @hiranya911 is the release still planned to be published this week 😄 ?

@lahirumaramba

Labels