fix: Fix the property names when initializing the SDK with the `ServiceAccount` type by lahirumaramba · Pull Request #2779 · firebase/firebase-admin-node
Navigation Menu
{{ message }}
firebase / firebase-admin-node Public
- Notifications You must be signed in to change notification settings
- Fork 415
Merged
fix: Fix the property names when initializing the SDK with the ServiceAccount type#2779
lahirumaramba merged 1 commit intomasterfrom
fix: Fix the property names when initializing the SDK with the ServiceAccount type#2779
lahirumaramba merged 1 commit intomasterfrom
Conversation
lahirumaramba
requested a review
from jonathanedey
lahirumaramba
mentioned this pull request
lahirumaramba
assigned
jonathanedey
lahirumaramba
changed the title
fix: Fix the property names when initializing the SDK with ServiceAcc…
fix: Fix the property names when initializing the SDK with the ServiceAccount type
jonathanedey approved these changes Nov 20, 2024
Copy link
Collaborator
jonathanedey
left a comment
jonathanedey
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
lahirumaramba
merged commit
380ef0a
into
master
lahirumaramba
deleted the
lm-fix-sa-cred
branch
lahirumaramba
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment